search

rangle / rangle-starter

48 stars 23 forks source link

Improve typescript source map support #126

Closed SethDavenport closed 8 years ago

SethDavenport commented 8 years ago

It should be possible to debug in the browser from the TypeScript source using source maps.

However our config isn't quite right.

SethDavenport commented 8 years ago

@clbond has figured it out for the ng2-minimal starter.

SethDavenport commented 8 years ago

@alexs you might be interested in this.

clbond commented 8 years ago

OK, this has been done in all of the TypeScript-based starters. The last PR remaining to be merged is at https://github.com/rangle/typescript-react-redux-starter/pull/146 - I am waiting for someone to review it before I merge since it's a more complicated change than the ones I did in the angular2 repos. Once that last PR is merged I think we can close this ticket.

SethDavenport commented 8 years ago

@clbond - thanks!

Did you do the angular 1 + typscript starter as well? https://github.com/rangle/angular-redux-starter

clbond commented 8 years ago

Ah, no, I'm sorry - I missed that one. Didn't realize there was another TS starter. Will do first thing in the morning. On Jun 13, 2016 2:01 PM, "Seth Davenport" notifications@github.com wrote:

@clbond https://github.com/clbond - thanks!

Did you do the angular 1 + typscript starter as well? https://github.com/rangle/angular-redux-starter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rangle/rangle-starter/issues/126#issuecomment-225659972, or mute the thread https://github.com/notifications/unsubscribe/ABspxByD0o80CQXoax2QMM21ZxuTtWJQks5qLZsIgaJpZM4IxdQR .

clbond commented 8 years ago

OK, angular-redux-starter is done now too. Implemented in https://github.com/rangle/angular-redux-starter/pull/135