search

rap2hpoutre / vue-picture-swipe

🖼 Vue Picture Swipe Gallery (a gallery of image with thumbnails, lazy-load and swipe) backed by photoswipe
MIT License
395 stars 50 forks source link

Added caption functinality #9

Closed ArtStepanyuk closed 6 years ago

ArtStepanyuk commented 6 years ago

-added caption functionality

title property should be present on image otherwise there wont be caption

rap2hpoutre commented 6 years ago

Thank you for your contribution! Does it still work without a title (in other words, title have to be optional and should not display a warning in console). I'm in a train for a few hours so I can't test it myself...

ArtStepanyuk commented 6 years ago

Hello, yes it works without the title, no errors are thrown, if there is no title property present on image object the preview won't have a caption, there is no error in console.

But it would be nice if you gave it a test run as well first before merging.

Thank you

rap2hpoutre commented 6 years ago

Sorry for late answer. I will try to merge it (and publish it) tomorrow.

ArtStepanyuk commented 6 years ago

No worries I'm glad to help

rap2hpoutre commented 6 years ago

Available in v0.4.0