Update AndroidManifest.xml

rapid7 / metasploit-payloads

Unified repository for different Metasploit Framework payloads

Other

1.75k stars 673 forks source link

Update AndroidManifest.xml #734

Open k41ed opened 1 week ago

k41ed commented 1 week ago

Update AndroidManifest for compatibility with Android 11-14

Updated targetSdkVersion to 33 for modern Android support.
Added android:exported attribute to MainActivity and components with intent filters as required by Android 12+.
Limited certain permissions (e.g., SMS, external storage) with maxSdkVersion for Android 11+.
Added tools:ignore="ProtectedPermissions" for WRITE_SETTINGS permission to suppress Lint warnings.
Declared optional hardware features to improve device compatibility.
Enabled legacy storage with requestLegacyExternalStorage for backward compatibility.

k41ed commented 1 week ago

Awaiting approval on this workflow so I can proceed with further modifications in some files. Thank you!

h00die commented 1 week ago

@k41ed, please have patience. There's likely about 50 people in the entire world who have permissions to merge this request. Of those, 10-20 likely aren't around or active any more. Of the remaining, not everyone is familiar with Android architecture, and the changes you've proposed. Of those remaining who work for rapid7, they'll also have to prioritize this request versus the others. I'd encourage you to give it a week or two, then ping again. Also, if it makes sense to combine this PR with some other changes, you may as well since it may be a while.

@timwr if you're bored and still around, this may speak to you!

k41ed commented 1 week ago

Thank you all for the feedback and insights. I completely understand that the process involves many steps and the priority of tasks may vary. I appreciate the effort everyone is putting into the project, and I'm happy to give it some more time

k41ed commented 1 week ago

I’ll work on fixing this as soon as possible

h00die commented 1 week ago

Are there any instructions on how to test this change? My assumption would be to create a gem, then go over to the metasploit side, install the gem, then create an apk via msfvenom. Then install it to a newer android phone, and you'll no longer get the warnings that the apk was designed for an older version of android. Do you have any notes from how you tested it that differ from this?