search

rapidsai / ci-imgs

https://hub.docker.com/u/rapidsai
12 stars 16 forks source link

Fix GHA warnings in diffs #170

Closed jakirkham closed 3 months ago

jakirkham commented 3 months ago

Our *.Dockerfiles are getting flagged for warnings by GHA. However each time a job runs it gets flagged. So we get dozens of comments in the diffs, which makes reviewing PRs here difficult

To fix this issue this cleans up the common warnings we have seen

We may also want to separately consider only raising these warnings once so as to keep PR reviews manageable

Edit: For clarity these are the GHA warnings that I see currently. It takes quite a bit of scrolling to get through them all

Screenshot 2024-08-15 at 2 39 48 PM
jakirkham commented 3 months ago

Thanks Bradley! 🙏

Honestly am having a hard time reviewing PRs because of these warnings. So wanted to speed up resolution. Hence addressing in this PR