search

rapidsai / cucim

cuCIM - RAPIDS GPU-accelerated image processing library
https://docs.rapids.ai/api/cucim/stable/
Apache License 2.0
359 stars 61 forks source link

Replace or drop `pytest-lazy-fixture` #755

Closed jakirkham closed 3 months ago

jakirkham commented 3 months ago

After some recent unrelated testing work, we learned that pytest-lazy-fixture is incompatible with pytest version 8.0.0 or newer. This has been the case for 6 months now as this issue notes: https://github.com/TvoroG/pytest-lazy-fixture/issues/65

Given this we may want to drop or replace this dependency

One option on the replacement side is pytest-lazy-fixtures, which it looks straightforward to switch to

jakirkham commented 3 months ago

cc @grlee77

grlee77 commented 3 months ago

It is not used for cucim.skimage or cucim.core test cases. but is used for some I/O related ones under python/cucim/tests/. It is imported here in a helper module loaded by the python/cucim/tests/conftest.py.

cc @gigony as original author of those test fixtures

gigony commented 3 months ago

Thanks @jakirkham and @grlee77 ! Let me check if I can replace it with pytest-lazy-fixtures.

jakirkham commented 3 months ago

This was done in PR: https://github.com/rapidsai/cucim/pull/756

Thanks Gigon! 🙏