search

rapidsai / cucim

cuCIM - RAPIDS GPU-accelerated image processing library
https://docs.rapids.ai/api/cucim/stable/
Apache License 2.0
359 stars 61 forks source link

Disable custom 2D separable filtering kernels on windows #770

Closed grlee77 closed 2 months ago

grlee77 commented 3 months ago

We currently bundle some custom 2D convolution kernels not present in CuPy. We have additional testing of these internel kernels, but I found that on the Windows platform a subset of these tests currently fail.

This MR disables auto-selection of these kernels on the Windows platform (will always fall back to CuPy's cupyx.scipy.ndimage kernels in this case). The test cases that are currently known to fail are skipped for now on Windows. Longer term it would be good to resolve the issues with the kernels, restore the test cases and enable use of these kernels on Windows.

jakirkham commented 3 months ago

Thanks Greg! 🙏

Can you please write up the test failure in a new issue so we have that for future reference?

grlee77 commented 3 months ago

uploaded the test failures in #771

grlee77 commented 3 months ago

@jakirkham, please approve if there are no further comments

jakirkham commented 2 months ago

/merge

jakirkham commented 2 months ago

Thanks for the ping Greg! 🙏

Missed the update