search

rapidsai / docs

RAPIDS Documentation Site
https://docs.rapids.ai
37 stars 52 forks source link

Disable librmm and libcudf docs #464

Closed vyasr closed 9 months ago

vyasr commented 11 months ago

These doxygen doc builds are both now incorporated into the Sphinx builds and need not be published separately. The rmm docs were published as part of the 23.12 release, so they can also be removed from the stable pages, but libcudf is only being merged this release so only the nightly can be removed. This PR should be merged after rapidsai/cudf#13846.

netlify[bot] commented 11 months ago

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
Latest commit 1746b3f30035d444d78dcc7777e9bf4621968108
Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/6581d28a4e5f62000854b548
Deploy Preview https://deploy-preview-464--docs-rapids-ai.netlify.app/api
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jarmak-nv commented 11 months ago

Can't add suggestions since the code wasn't modified, but I think we should add a note in librmm and libcudf pointing users to the RMM/cuDF docs page so people don't get confused when they get to librmm and see there's no stable/nightly docs.

Probably would do it as a newline after the library descriptions.

vyasr commented 11 months ago

@jarmak-nv does this change look like what you were intending? I didn't include a newline because I wasn't sure if that would work.

jarmak-nv commented 11 months ago

😞 \n is a no go. Thanks for trying!

vyasr commented 11 months ago

Worth a shot! @jarmak-nv feel free to merge whenever you approve. I can make the changes to cudf/rmm separately.

jarmak-nv commented 11 months ago

👍 Will do once https://github.com/rapidsai/cudf/pull/13846 goes in

vyasr commented 10 months ago

We're no longer planning to remove the cudf doxygen docs in rapidsai/cudf#13846. We want to spend a bit more time iterating on them until everyone is happy with their appearance. I'll reopen this PR from draft once more of those changes are completed and I'll update this PR at that time based on the timeline.

vyasr commented 9 months ago

The rmm piece is done in #478. I'm going to close this PR for now. I can reopen it for cudf if and when we're ready to make the change for just cudf.