search

rappasoft / laravel-authentication-log

Log user authentication details and send new device notifications.
MIT License
772 stars 94 forks source link

UserAgent triggering false new device notifications #40

Open sunscreem opened 2 years ago

sunscreem commented 2 years ago

This packages works great, just I'm experiencing a few "false" new device notifications.

My question is should a user get a notification if they have updated their browser?

Take these two UserAgent strings:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15

I'd suggest the version should be ignored?

lucasjose501 commented 2 years ago

I noticed that behavior too, I think the only other way is using cookies and we know that lately this could create some issues with cookie laws. Same thing for dynamic IP address.

alekbless commented 2 years ago

Agreed, a lot of NewDevice Notifications is being created by this behavior. Configurable ignoring browser version may help.

justbadproger commented 2 years ago

Author does not answer issue for a long time, I also do not observe activity in repository last time. Can I consider this package seriously for new application or mb better choose something else?

xavicabot commented 1 year ago

Same problem, a lot of log notifications with this

The script tried to call a method on an incomplete object. Please ensure that the class definition "Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice" of the object you are trying to operate on was loaded before unserialize() gets called or provide an autoloader to load the class definition {"exception":"[object] (Error(code: 0): The script tried to call a method on an incomplete object. Please ensure that the class definition \"Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice\" of the object you are trying to operate on was loaded before unserialize() gets called or provide an autoloader to load the class definition at /home/forge/app.unancor.com/vendor/laravel/framework/src/Illuminate/Notifications/SendQueuedNotifications.php:125)

Any suggests?

emadabuselmiya commented 1 year ago

Same problem, a lot of log notifications with this TypeError Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice::__construct(): Argument #1 ($authenticationLog) must be of type Rappasoft\LaravelAuthenticationLog\Models\AuthenticationLog, Yadahan\AuthenticationLog\AuthenticationLog given, called in E:\smart trade\website-smart-trade\vendor\rappasoft\laravel-authentication-log\src\Listeners\LoginListener.php on line 43

I used muti Gurad auth

Any suggests?

mit-0044 commented 1 year ago

mail is not sending when i login from new device of failed to login