search

raspberrypi / rpi-imager

The home of Raspberry Pi Imager, a user-friendly tool for creating bootable media for Raspberry Pi devices.
https://www.raspberrypi.com/software
Other
1.73k stars 263 forks source link

[BUG]: Existing users are overwritten when applying custom settings #831

Open besi opened 9 months ago

besi commented 9 months ago

What happened?

  1. I have an image with custom users pre-defined.
  2. I flash the image to the an SD card using custom settings (wifi / hostname and base user)
  3. The existing user was overwritten by those settings
  4. The image, which relies on that deleted user is now not working as intended

I would expect the OS customisations to be applied without the deletion of any existing users.

Version

1.8.5 (Default)

What host operating system were you using?

macOS

Host OS Version

12.6.2 (21G320)

Selected OS

Custom Talkkonnect image

Which Raspberry Pi Device are you using?

Raspberry Pi Zero, Zero W, Zero WH

What kind of storage device are you using?

microSD Card in a USB reader

OS Customisation

Relevant log output

No response

tdewey-rpi commented 9 months ago

OS Customisation should not have been offered when you selected the custom image.

We have no way of knowing, at the point of selecting a custom image, which of the customisation schemes we should use - and offering that choice to a user is not one I'm prepared to make in the GUI as I'm not convinced new users could make an informed choice at that part of the flow.

As such, I'm going to remove the OS customisation UI flow when you've selected a custom image. Note that this will not remove the ability to apply customisations via the rpi-imager --cli.