raspberrypi / userland

Source code for ARM side libraries for interfacing to Raspberry Pi GPU.
BSD 3-Clause "New" or "Revised" License
2.05k stars 1.09k forks source link

Update the GPS version to 23 #594

Closed JamesH65 closed 5 years ago

JamesH65 commented 5 years ago

Buster now has gpsd version 23, (up from 22)

This PR updates the camera code to reflect the change.

JamesH65 commented 5 years ago

Note, the change to gps.h is simply a copy of the v23 version over the top of the v22 version.

6by9 commented 5 years ago

Do we want to just do this simplistic bump the version? It'll now be broken on Stretch.

I haven't looked at what symlinks or automagic mangling of the library name happens in dlopen, but it'd be nice to be able to load a generic library filename and then check against supported versions. Don't know if that is actually possible though.

JamesH65 commented 5 years ago

Do we want to just do this simplistic bump the version? It'll now be broken on Stretch.

I haven't looked at what symlinks or automagic mangling of the library name happens in dlopen, but it'd be nice to be able to load a generic library filename and then check against supported versions. Don't know if that is actually possible though.

I did wonder about that, but on the whole we only have support for the current version of the distro, ie backward rather than forward compatibility. Might be worth asking @XECDesign though.

XECDesign commented 5 years ago

Stretch is unlikely to get libraspberrypi0 updates. If you would like to provide an option for people to build it themselves, you could use ifdefs or dynamically load the appropriate .so at runtime and deal with whatever API differences might be relevant.

Personally, I'm in the "we don't support old releases" camp.

6by9 commented 5 years ago

Fine, ditch libgps.22