raspberrypi / userland

Source code for ARM side libraries for interfacing to Raspberry Pi GPU.
BSD 3-Clause "New" or "Revised" License
2.05k stars 1.09k forks source link

raspistill: Adjust framerate limits on long exposures. #622

Closed naushir closed 4 years ago

naushir commented 4 years ago

Need to reduce the min fps limit to 0.005 for 200s exposures available in HQ cam.

Not entirely sure why we have different limits based on exposure, but I have kept that as-is.

naushir commented 4 years ago

@6by9, @JamesH65, this is why we were limited to 20s exposures for HQ cam.

6by9 commented 4 years ago

Not entirely sure why we have different limits based on exposure, but I have kept that as-is.

It's the only way of switching into the longer exposure time mode on ov5647.

6by9 commented 4 years ago

LGTM

6by9 commented 4 years ago

Except it needs to be done in the other apps too https://github.com/raspberrypi/userland/blob/master/host_applications/linux/apps/raspicam/RaspiStillYUV.c#L648 https://github.com/raspberrypi/userland/blob/master/host_applications/linux/apps/raspicam/RaspiVid.c#L1604 https://github.com/raspberrypi/userland/blob/master/host_applications/linux/apps/raspicam/RaspiVidYUV.c#L924

naushir commented 4 years ago

Except it needs to be done in the other apps too

Done.

6by9 commented 4 years ago

I'm happy now.

JamesH65 commented 4 years ago

LGTM

JamesH65 commented 4 years ago

@popcornmix Another userland change to get back to the main build.