raspberrypi / userland

Source code for ARM side libraries for interfacing to Raspberry Pi GPU.
BSD 3-Clause "New" or "Revised" License
2.05k stars 1.09k forks source link

Documentation for the `pwm_speedup` command in vcgencmd #709

Closed seamusdemora closed 3 years ago

seamusdemora commented 3 years ago

vcgencmd commands lists the command pwm_speedup. It also provides this link to "further documentation. I don't see any documentation for the pwm_speedup command at this URL. Does any documentation exist? If so, where can I find it?

pelwell commented 3 years ago

I'd not come across it before, but from reading the code it simply acts as a multiplier for the audio PWM clock. The commit dates back to 2013 and the message says Add pwm_speedup hack for benchmarking.

Nothing to see here - move along.

seamusdemora commented 3 years ago

@pelwell

Nothing to see here - move along.

OK - I appreciate the feedback, but your answer also suggests that you feel this is "not your problem"?? Or am I reading something into it? I was under the impression this code was unique to RPi hardware, so apologies if I've brought someone else's oversight to your doorstep.

popcornmix commented 3 years ago

Some gencmd's (and other interfaces) were purely added for RPi engineers to debug things. Use of them is likely to make the system behave in unexpected ways. Documenting these interfaces gives the impression they are supported and is likely to generate more confusion.

seamusdemora commented 3 years ago

Documenting these interfaces gives the impression they are supported and is likely to generate more confusion.

I suppose one idea might be to remove any reference to unsupported gencmd's. That has the obvious benefit of saving me time looking for something that doesn't exist - and for you having to answer a question that's pursued doggedly.