ratgdo / esphome-ratgdo

ratgdo for ESPHome
GNU General Public License v2.0
357 stars 108 forks source link

ota: add esphome platform #291

Closed flavio-fernandes closed 5 months ago

flavio-fernandes commented 5 months ago

Starting on version 2024.6.0, at least one platform must be specified for 'ota'; add 'platform: esphome' for original OTA functionality.

Fixes: https://github.com/ratgdo/esphome-ratgdo/issues/289

bdraco commented 5 months ago

This can probably go in base.yaml instead

flavio-fernandes commented 5 months ago

This can probably go in base.yaml instead

Hmm... that would mean that the entire ota section should be moved from all the files I changed, right @bdraco ?

Do you agree with that approach, @PaulWieland ?

PaulWieland commented 5 months ago

Yes it should be part of the base yamls

flavio-fernandes commented 5 months ago

Yes it should be part of the base yamls

Gotcha! @bdraco + @PaulWieland : PTAL and see if I got it right.

bdraco commented 5 months ago

Looks correct.

Will have to dig into why the firmware doesn't build. I don't think its specific to this change

bdraco commented 5 months ago

https://github.com/ratgdo/esphome-build-action has been updated but looks like there is still an issue with safe_mode

bdraco commented 5 months ago

I need to recreate the PR on the main repo

bdraco commented 5 months ago

superceeded by https://github.com/ratgdo/esphome-ratgdo/pull/293

Thanks @flavio-fernandes

flavio-fernandes commented 5 months ago

superceeded by #293

Thanks @flavio-fernandes

NP. Thank you for fixing the build issue!