search

ratgdo / homekit-ratgdo

A native HomeKit implementation of a Security+ 2.0 garage door controller based on ratgdo hardware
https://ratgdo.github.io/homekit-ratgdo/
GNU General Public License v3.0
215 stars 21 forks source link

Make LED polarity configurable #221

Closed jgstroud closed 3 months ago

jgstroud commented 3 months ago

Some users really don't like having the LED on all the time. I personally like seeing it on to indicate it's alive and well. We can make the polarity configurable and optionally only allow it to be on when motion is detected in the garage. The LED may also attract bugs in some environments.

dkerr64 commented 3 months ago

I don't like that the LED is on continuously either. My recommendation would be...

We need to decide what "activity" should be. Network activity is often used, but for us it may be more relevant to use garage-door comms activity. Or we could tie it to our logging activity, flash it every time we log? That should cover most activity without causing the LED to appear like it is always on.

jgstroud commented 3 months ago

Well, it already blinks on activity on the serial link. I think we leave that part as is.

dkerr64 commented 3 months ago

So, you propose an option that essentially inverts current behavior... so if users prefer the light to be mostly off they can have that.

jgstroud commented 3 months ago

Yeah, I think that's the easiest solution without overcomplicating anything. But I don't really have a strong opinion about it. Ever since it was implemented, it seems like we get about 50/50 feedback on users that would prefer it mostly on vs those that would prefer it mostly off.

dkerr64 commented 3 months ago

I've figured out how to implement so I will code it up tonight and see how well it works.

dkerr64 commented 3 months ago

Implemented in PR #220

dkerr64 commented 3 months ago

Implemented in v1.7