rauchg / slackin

Public Slack organizations made easy
http://rauchg.com/slackin/
MIT License
6.51k stars 1.34k forks source link

Fix signup via badges #353

Closed chromy closed 6 years ago

chromy commented 7 years ago

Signups via the badge go down a slightly different path than signups via the main page (eventually ending up at https://example.com/iframe/dialog, https://github.com/rauchg/slackin/blob/master/lib/index.js#L248). Unfortunately this path doesn't pass gcaptcha_sitekey to splash (https://github.com/rauchg/slackin/blob/master/lib/splash.js#L3) which results in this error when you try to sign up:

Uncaught TypeError: Cannot read property 'value' of undefined
    at HTMLBodyElement.<anonymous> (client.js:23)

The fix is to pass gcaptcha_sitekey which I have tested locally.