Next.js migration - Githubissues

rauchg / slackin

Public Slack organizations made easy

http://rauchg.com/slackin/

MIT License

6.5k stars 1.35k forks source link

Next.js migration #406

Closed lfades closed 2 years ago

lfades commented 4 years ago

Moved the HTML and CSS to Next.js pages, and the API routes for the Slack endpoints, the migration is ready and here are some key differences:

All Slack API calls are using the new OAuth recommended by Slack except one, the only way to invite an user is by using an undocumented API and a legacy token, therefore the current setup still requires a legacy token, the only difference is that an OAuth token can be used for the other API calls
The API section and iframe were removed
The old implementation has been deleted

vercel[bot] commented 4 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

ghost commented 4 years ago

Slack subdomain is not defined

lfades commented 4 years ago

@tanahatas Can you expand more on what do you mean?. To make the app work you need to follow the steps in the readme (the readme in this PR)

ghost commented 4 years ago

How to input my slack subdomain like blablabla.slack.com ?

Because your PR using https://${teamName}.slack.com and ${teamName} is undefined.

lfades commented 4 years ago

@tanahatas The team name is returned by /api/v1/team, which is fetched in getInitialProps to return the info of the team to the components that require teamName.