raulgomis / beerstrap

Startup project designed to ease and accelerate software development. Ideal for startups and web developers who want to rapid-prototype and develop products within weeks.
http://raulgomis.github.io/beerstrap/
Apache License 2.0
28 stars 10 forks source link

Error 500 if mail authentication failed at RegisterController #6

Closed konkit closed 10 years ago

konkit commented 10 years ago

If authentication with email fails, there is AuthenticationFailed exception thrown and site is displaying 500 error instead of showing error gracefully (f. e. via flash.error )

raulgomis commented 10 years ago

Yes! you are right, the standard way does not work because it is the main layout which has this functionality to treat the flash messages. The login should have the same "api" to show the messages, so this functionality should be moved to a template or taglib in order to reuse the code. Ideally in the future I should think to have a more flexible object to build the flash messages, rather than the flash object. But this is OK for now.