[Dashboard] Update speedscope from 1.5.3 to the latest 1.13.0

ray-project / ray

Ray is an AI compute engine. Ray consists of a core distributed runtime and a set of AI Libraries for accelerating ML workloads.

https://ray.io

Apache License 2.0

34.24k stars 5.81k forks source link

[Dashboard] Update speedscope from 1.5.3 to the latest 1.13.0 #23118

Open mattip opened 2 years ago

mattip commented 2 years ago

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

speedscope is vendored into the dashboard at version 1.5.3 from 2020-1-16. I might be nice ot update it to the latest 1.13.0. Filtering the changelog for relevant improvements, I see improvements in performance, a dark mode, support for retina displays, improvements in labeling, and improvements in search.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

stale[bot] commented 2 years ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

mattip commented 2 years ago

Is the dashboard team interested in updating the speedscope version?

scottsun94 commented 2 years ago

Thanks for reporting this! cc @alanwguo for thoughts.

mattip commented 2 years ago

In the meantime, speedscope 1.14 has been released.

scottsun94 commented 2 years ago

I took a quick look at speedscope. It is used for visualizing the profiling info, especially the flamegraphs. I believe it was previously used in the old dashboard for profiling actors?

In Ray 2.0, we made the previous experimental dashboard be the default dashboard. Profiling actors is not supported in it for now. When we work on profiling related features in the new dashboard, this library will be helpful.

stale[bot] commented 1 year ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

scottsun94 commented 1 year ago

@alanwguo shall we close it for now?

stale[bot] commented 1 year ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

mattip commented 1 year ago

If speedscope is no longer used, perhaps the vendored code from an older version should be removed.

stale[bot] commented 1 year ago

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.