search

raymak / contextualfeaturerecommender

Mozilla Public License 2.0
4 stars 2 forks source link

on shutdown the logger does not have enough time to increment the log counter #250

Open raymak opened 8 years ago

raymak commented 8 years ago

which leads to having startup and shutdown messages with the same number

raymak commented 8 years ago

have to check if unload is called for logger storage before logger.js

gregglind commented 8 years ago

isn't this what unload.when is for, which you already do?

raymak commented 8 years ago

yes, but on shutdown sometimes the promise won't get resolved. I think the solution would be to to use something like AsyncShutdown but it's not worth it for just a shutdown message.

gregglind commented 8 years ago

fwiw, the addon utils do it and phone home with telemetry.

gregglind commented 8 years ago

@raymak, how do I reproduce this? Is it still a problem? If not, explain and close, plz.

raymak commented 8 years ago

Not easy to reproduce. Happens only for some users and maybe once every 20 shutdowns.