search

rbatten / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
0 stars 0 forks source link

Set button arrow icons according to locale's text direction #688

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Set button arrow icons according to locale's text direction.

media-playback-start-symbolic in LTR,
media-playback-start-rtl-symbolic in RTL.

media-seek-forward-symbolic in LTR,
media-seek-forward-rtl-symbolic in RTL.

media-seek-backward-symbolic in LTR,
media-seek-backward-rtl-symbolic in RTL.

media-skip-forward-symbolic in LTR,
media-skip-forward-rtl-symbolic in RTL.

media-skip-backward-symbolic in LTR,
media-skip-backward-rtl-symbolic in RTL.

See patch.

Original issue reported on code.google.com by yosef...@gmail.com on 23 Jun 2013 at 10:32

Attachments:

GoogleCodeExporter commented 8 years ago 
I really like the idea of this patch, unfortunately it doesn't apply to SVN. 
Can you provide a current patch?

Original comment by kdeko...@gmail.com on 23 Jun 2013 at 12:45

GoogleCodeExporter commented 8 years ago 
How?
I do not know to use SVN.
I'm used to git.

Original comment by yosef...@gmail.com on 23 Jun 2013 at 1:28

GoogleCodeExporter commented 8 years ago 
To get a readonly copy of the code run the following command and it will create 
a gnome-mplayer directory in your current working directory.

svn checkout http://gnome-mplayer.googlecode.com/svn/trunk/ gnome-mplayer

Use 'svn up' in the gnome-mplayer directory to update the tree with the latest 
code

You will probably need to build gmtk from svn as well. you can get it from here

svn checkout http://gmtk.googlecode.com/svn/trunk/ gmtk

Then run the normal configure command, make and make install to build the code 
on your machine.

Original comment by kdeko...@gmail.com on 23 Jun 2013 at 1:31

GoogleCodeExporter commented 8 years ago 
How to create a commit (and patch)?

Original comment by yosef...@gmail.com on 23 Jun 2013 at 1:38

GoogleCodeExporter commented 8 years ago 
Just use svn diff on the directory and then email me the output and I will 
commit it. Send me enough high quality patches and I'll give you commit access.

Original comment by kdeko...@gmail.com on 23 Jun 2013 at 1:41

GoogleCodeExporter commented 8 years ago 
I attached a diff file.

Original comment by yosef...@gmail.com on 23 Jun 2013 at 3:04

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks! Patch applied

Original comment by kdeko...@gmail.com on 23 Jun 2013 at 5:24