search

rcarriga / vim-ultest

The ultimate testing plugin for (Neo)Vim
MIT License
385 stars 15 forks source link

change regex for elixir#exunit to enable multi-line do / feature blocks #112

Closed lessthanseventy closed 1 year ago

lessthanseventy commented 2 years ago

My regex skills aren't the greatest, but I believe this will work to fix #111

lessthanseventy commented 2 years ago 
    feature "clients display correct status", %{
      session: session,
      clients: clients
    } do
  feature "client sees no callout when there are no matches",
          %{session: session, client: client, aide: aide} do

This still doesn't catch these tests either, and I'm not sure how to fix that yet. Is there a better approach to the regex match?

rcarriga commented 2 years ago

Thanks for the PR! Since we're trying to cover a few cases here could you a small test file to here https://github.com/rcarriga/vim-ultest/tree/master/tests/mocks/test_outputs and a corresponding test in https://github.com/rcarriga/vim-ultest/blob/master/tests/unit/handler/parsers/test_file.py. Large regexes are pretty tough to maintain so would be great to be able to make sure it doesn't break :sweat_smile: