rcdexta / react-trello

Pluggable components to add a kanban board to your application
https://rcdexta.com/react-trello/
MIT License
2.19k stars 481 forks source link

Cannot drop a card near the bottom of a lane #203

Open sylvain-hamel opened 5 years ago

sylvain-hamel commented 5 years ago

Describe the bug When dropping a card, it has to be dropped very close the the previous card, otherwise the drop is cancelled

To Reproduce See gif

Desktop (please complete the following information):

dapi commented 5 years ago

Here is minor fix - https://github.com/rcdexta/react-trello/pull/265

But I think the best way to show placeholder like it trello do. And place card into bottom placeholder even it dropped outside of the lane bottom.

pWpsRqfTDo

Than this is a new feature

iamriel commented 4 years ago

@dapi first of all, thanks for this project. If I understand it correctly, Than this is a new feature, do you mean dropping the card into the bottom even outside the lane bottom is still not supported? If yes, is it actively worked on? If not, I can check the source and will try to work on it. Thanks!

iamriel commented 4 years ago

Right now, I did a dirty fix to achieve this through css:

.react-trello-lane {
  .smooth-dnd-container {
    min-height: calc(100vh - 270px);
  }
}
bmoffitt1990 commented 4 years ago

@iamriel Where did you place this code?

iamriel commented 4 years ago

@bmoffitt1990 Sorry for the late reply, I just placed it in my css file, outside of this project. You can place it anywhere as long as it points to the correct class .react-trello-lane .smooth-dnd-container.

lveillard commented 4 years ago

+1 to this. Nice to have a quick fix but would be nice to have this by default Thank you for the css fix, I found the same but my css code was uglier (padding-bottom: 300px) haha

to give more info: lZcEdRNv6o

lveillard commented 4 years ago

And with the fix: 4wCfhnbDHJ

I think this is actually both a fix and a feature: A fix would be to apply this css code

A feature would be to do it like trello does, with the placeholder shadow and even outside of the lane