search

rchaganti / DSCResources

Custom DSC resource modules by PowerShell Magazine
http://www.powershellmagazine.com
61 stars 26 forks source link

Fix check for presence of parameter AllowManagementOS #1

Closed nicholasdille closed 9 years ago

nicholasdille commented 9 years ago

The original test for AllowManagementOS only executed the code if AllowManagementOS was set to $true. In my case, it was necessary to prevent a network adapter to be created on the management OS.

rchaganti commented 9 years ago

Thank you for the update! I merged this pull request but this particular resource is from resource kit. I modified it for my own purpose. We need to check if there are updates to this in wave 10 release.

nicholasdille commented 9 years ago

Hi,

thanks for the heads up concerning the original resource. I did not know how much of xHyperV remained. But I guess it is a good start to fix this in your repo. What is your recommendation for a bug report for xHyperV - TechNet Gallery for the individual resource?

Kind regards Nicholas

Von: Ravikanth C Gesendet: ‎03.‎03.‎2015 03:01 An: rchaganti/DSCResources Cc: Nicholas Dille Betreff: Re: [DSCResources] Fix check for presence of parameter AllowManagementOS (#1)

Ravikanth C notifications@github.com hat am 3. März 2015 um 03:01 geschrieben:

Thank you for the update! I merged this pull request but this particular resource is from resource kit. I modified it for my own purpose. We need to check if there are updates to this in wave 10 release.

Reply to this email directly or view it on GitHub: https://github.com/rchaganti/DSCResources/pull/1#issuecomment-76872570

rchaganti commented 9 years ago

@nicholasdille check out https://github.com/PowerShell

nicholasdille commented 9 years ago

Awesome, preparing a pull request :-) Thanks for the heads up!

------ Originalnachricht ------ Von: "Ravikanth C" notifications@github.com An: "rchaganti/DSCResources" DSCResources@noreply.github.com Cc: "Nicholas Dille" nicholas.dille@mailbox.org Gesendet: 16.04.2015 07:07:15 Betreff: Re: [DSCResources] Fix check for presence of parameter AllowManagementOS (#1)

@nicholasdille check out https://github.com/PowerShell

— Reply to this email directly or view it on GitHub.