Mupen64 creates bad screenshot png files.

[GoogleCodeExporter]

Screenshots taken using glN64 video plugin are unreadable by most picture
viewer programs. I've attached a sample png from Super Mario 64.

Original issue reported on code.google.com by ebenbl...@gmail.com on 25 Mar 2008 at 6:09

Attachments:

• mupen64_000.png

[GoogleCodeExporter]

I've never had a problem with the PNGs dumped by glN64.  I opened the attached 
PNG
with the Windows XP built-in viewer and it had no problems.  On the Linux side, 
my
downstream project is integrated with libpng and it hasn't had any problems 
with the
images generated by glN64.  With which viewer programs have you experienced 
problems?

Original comment by richard...@gmail.com on 28 Mar 2008 at 5:02

[GoogleCodeExporter]

Hmm, that's interesting that you don't have problems with the png file. I've 
viewed
the file using xv (linux), gimp (winXP), and Microsoft Photo Editor (winXP). xv 
gives
a warning "libpng error: Read Error", but displays the picture anyway. gimp 
gives a
similar warning "Error while reading C:\...\mupen64_000.png. File corrupted?", 
but
still opens the picture for editing. Microsoft Photo Editor pops up a dialog 
saying
"Error Reading File" and does not open the picture.

Original comment by ebenbl...@gmail.com on 28 Mar 2008 at 6:29

[GoogleCodeExporter]

I also get this error, same error messages.

Original comment by sgorman07@gmail.com on 2 Apr 2008 at 1:47

Attachments:

• mupen64_000.png

[GoogleCodeExporter]

I tested and got the reported warning message from GIMP.  GQView didn't 
complain.  So
there must be some issue with the file but not severe enough to prevent most 
programs
from opening the file.  It should be looked into at some time.

Original comment by richard...@gmail.com on 5 Apr 2008 at 1:23

[GoogleCodeExporter]

Yeah, it seems to be a very minor error with the file. Changing the priority to 
low.

Original comment by ebenbl...@gmail.com on 5 Apr 2008 at 3:33

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

This should be fixed with new code changes for ReadScreen.

Original comment by sgorman07@gmail.com on 23 Apr 2008 at 8:36

• Changed state: Fixed

[GoogleCodeExporter]

Actually the new screenshot code uses the same code as glN64 did, but for all
plugins.  So this issue probably still remains.

Ebenblues, did you get this problem when running from a compiled from source 
build,
or a pre-built binary from me?  If it was compiled from source, which version of
libpng does your system have?

Original comment by richard...@gmail.com on 23 Apr 2008 at 12:12

• Changed state: Accepted

[GoogleCodeExporter]

Upload Failed! Image Magick failed. Invalid format (jpg|gif|png|bmp|tif)

Still getting the error, sorry for closing this issue.

Original comment by sgorman07@gmail.com on 23 Apr 2008 at 5:09

[GoogleCodeExporter]

Updating status to Mupen64 creates bad screenshot png files, we must figure 
this one
out before 1.4

Original comment by sgorman07@gmail.com on 23 Apr 2008 at 5:10

• Changed title: Mupen64 creates bad screenshot png files.
• Added labels: Component-Mupen64, Milestone-1.4, Priority-Medium
• Removed labels: Component-glN64, Priority-Low

[GoogleCodeExporter]

I've seen this problem on a version that was compiled from source. I haven't 
tried it
with the prebuilt binaries, although I would expect it to still have the libpng
dependency. I'm using libpng 1.2.18 (Slackware 12 default).

Original comment by ebenbl...@gmail.com on 23 Apr 2008 at 7:36

[GoogleCodeExporter]

To what are you uploading which generates the invalid format error?  Can 
somebody try
the attached image?  This was generated by rice video with a clean build of rev 
292
on my 64-bit system.

Original comment by richard...@gmail.com on 24 Apr 2008 at 12:35

Attachments:

• super_mario_64-000.png

[GoogleCodeExporter]

I did not get errors on the image you uploaded

Original comment by ebenbl...@gmail.com on 24 Apr 2008 at 12:52

[GoogleCodeExporter]

Can you try grabbing the same approximate shot on your machine (it's just a few
seconds into SM64) and uploading it to see if you get the error?  If so, it's
probably your libpng.

Original comment by richard...@gmail.com on 24 Apr 2008 at 12:54

[GoogleCodeExporter]

I tried upgrading to libpng-1.2.25 (slackware-current), but get the same 
error...

Original comment by ebenbl...@gmail.com on 24 Apr 2008 at 6:22

Attachments:

• super_mario_64-001.png

[GoogleCodeExporter]

I still believe that this is a problem with your system.  I tried using image
magick's "convert" with your image and got this:

convert: Expected 6943 bytes; found 3587 bytes `super_mario_64-001.png'.
convert: Read Exception `super_mario_64-001.png'.
convert: Corrupt image `super_mario_64-001.png'.
convert: missing an image filename `super_mario_64-001.jpg'.

So it's definitely bad.  I did the same with my image and got no errors.  So 
let's
try a perfect apples-to-apples comparison.  Set your rice video resolution to 
640x480
and do:

./mupen64plus --testshots 140 --nogui --gfx ./plugins/ricevideo.so --audio
./plugins/dummyaudio.so /mygamepath/Super\ Mario\ 64\ \(U\)\ \[\!\].z64 

I did this, using both 32-bit and 64-bit builds, and the two PNGs generated were
bit-identical and passed through "convert super_mario-000.png 
super_mario-000.jpg"
with no errors.  I'm using libpng-1.2.24.  The PNG generated is attached.

Original comment by richard...@gmail.com on 24 Apr 2008 at 1:14

Attachments:

• super_mario_64-000.png

[GoogleCodeExporter]

I'm using glN64, not rice. Rice still has problems on my system, but I can try 
taking
a screenshot with rice rendering the picture (it'll just be all white due to 
issue
19), but maybe that can help us narrow down the problem to glN64.

Original comment by ebenbl...@gmail.com on 24 Apr 2008 at 3:23

[GoogleCodeExporter]

Oh I forgot about your issues with Rice.  Let me do this again but with glN64 - 
they
all use the same PNG writing code now anyway.

Original comment by richard...@gmail.com on 24 Apr 2008 at 7:50

[GoogleCodeExporter]

I will be testing against your files too richard.

Original comment by sgorman07@gmail.com on 24 Apr 2008 at 9:14

[GoogleCodeExporter]

okay ricevideo works at 640x480 the frame was the same, with slight variations 
in
pixel placement (could be card based)...

It might be for higher resolutions... let me try something

Also my test returned no errors, and it has in the past... sooo i dont know.

Original comment by sgorman07@gmail.com on 24 Apr 2008 at 9:27

[GoogleCodeExporter]

Even big resolutions work with RiceVideo... now to test with glN64
http://i28.tinypic.com/142fq84.png - big res.

Original comment by sgorman07@gmail.com on 24 Apr 2008 at 9:28

[GoogleCodeExporter]

http://i25.tinypic.com/2m4ab1v.png - works with glN64... so whats the issue? 
LOL this
is becoming weird.

Original comment by sgorman07@gmail.com on 24 Apr 2008 at 9:31

[GoogleCodeExporter]

Here's the same shot from glN64, frame 140.

Original comment by richard...@gmail.com on 24 Apr 2008 at 11:24

Attachments:

• super_mario_64-000.png

[GoogleCodeExporter]

Is this still viable?

Original comment by sgorman07@gmail.com on 9 May 2008 at 4:09

[GoogleCodeExporter]

I think we've decided this problem is dependent on the version of libpng that's
installed on the box and not a mupen bug. Marking invalid.

Original comment by ebenbl...@gmail.com on 9 May 2008 at 4:23

• Changed state: Invalid