search

rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data
https://growth.rcpch.ac.uk
MIT License
8 stars 11 forks source link

custom theme style improvements and fixes #113

Closed gdfreitas closed 1 month ago

gdfreitas commented 1 month ago

Changes

Source Issue https://github.com/rcpch/digital-growth-charts-react-component-library/issues/111

  1. Fixes font-style property being used for setting font-weight values 1.1 Now it supports both font-style and font-weight properties, defaults were kept.

  2. Adds support for customizing a few properties from existing style objects, as well as new ones introduced in this merge request.

  3. CustomThemeStylesChart story was added just as a reference, it can be removed before incorporating this pull request, if you feel so. I thought it would be nice to have a dedicated story to show how customizable the chart is apart of existing themes.

@eatyourpeas

eatyourpeas commented 1 month ago

Hi @gdfreitas I am really sorry polluted this PR a bit - meant to bring it up to date with live before reviewing (I have updated a few things recently) and ended up in merge-conflict purgatory. This all looks great and I am generally happy with it. The story is good to have - if you are happy to add to the RCPCHChart.mdx with some documentation about what you have done and so on would be great. Really useful. A couple of things - the fonts currently in the component are only montserrat regular, bold and italic. Their weights I think therefore are 400 and 700 and these are the only ones included in the fonts folder. Probably for this reason I am not seeing an impact if I change the prop. I did this partly because we did not need the range of weights. Do you need specific font weights or fonts? If so do you want to add these? They would need converting to b64 and then importing in RCPCHChart.tsx in the GlobalStyle styled-div. I think best is if you are happy to look at these small items and resubmit a fresh PR and I will be less of a klutz with that one and merge into live, rather than the other way round that turned out more complicated than I expected.

gdfreitas commented 1 month ago

Hi @eatyourpeas as we discussed, I'm closing this in favor of https://github.com/rcpch/digital-growth-charts-react-component-library/pull/117, which is still a work in progress for now. Thank you.