search

rcpch / digital-growth-charts-react-component-library

A typescript React library for displaying RCPCH Digital Growth Charts from API data
https://growth.rcpch.ac.uk
MIT License
8 stars 11 forks source link

add support for different logo variants #119

Closed gdfreitas closed 4 weeks ago

gdfreitas commented 1 month ago

Feature

Introduces a logoVariant property that accepts:

top (default)

image

bottom

image

legend.

In our use case would like use legend.

image

What do you guys think?

eatyourpeas commented 4 weeks ago

Bumping this decision to @mbarton : possibly need a copyright/TM logo here next to RCPCH. Not also sure if having the logo present in the 'powered by' statement.

mbarton commented 4 weeks ago

I don't know what decision making process in the college would decide where the logo should be and if it's required. So to avoid any unnecessary delays in your testing I would suggest we go with "Powered by RCPCH Digital Growth Charts - Version XXX" and no logo.

gdfreitas commented 4 weeks ago

Hi @mbarton @eatyourpeas I updated the text according to your feedback. Thanks.

gdfreitas commented 4 weeks ago

Hi @mbarton what do you think about using . instead of - ?

From Powered by RCPCH Digital Growth Charts - Version XXX to Powered by RCPCH Digital Growth Charts. Version XXX

I can do the change if you agree.

eatyourpeas commented 4 weeks ago

Hi @gdfreitas I hope you don't mind me pushing to this PR. I think this is great and thank you for you time and thought putting it together. The extra bits I have added:

  1. fixed the broken tests
  2. added a dependency for storybook that must have fallen out with my last update to live (you will see I have added prettier back in and fixed all the css parsing errors in the tests in a previous PR to live)
  3. added 2 more stories - these are really just to demonstrate your logo presets in the context of prematurity where the age correction toggle is visible.

bottom

image

legend

image