search

rctn / sparsecoding

Reference sparse coding implementations for efficient learning and inference.
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Formatting & formatting guidelines #27

Closed belsten closed 2 years ago

alvinz-matician commented 2 years ago

autopep8?

belsten commented 2 years ago

@alvinz-matician I'm unfamiliar with autopep8. Would this be something that would be locally run before pushing code, or automated through github actions?

alvinz-matician commented 2 years ago

It's a Python auto-formatter for PEP8 standards, I just wanted to put it on your radar. I was thinking that it could be nice to add as a PR check in GitHub actions.

9q9q commented 2 years ago

from a quick search, it looks like flake8 wraps a few things including pyflakes (statically checks for logical errors) and pycodestyle (formerly pep8). autopep8 does automatic formatting according to pep8. would be cool to have both but if we have to pick one to start with maybe flake8? action: https://github.com/py-actions/flake8

belsten commented 2 years ago

All new changes look good to me.

alvinz-matician commented 2 years ago

I'm rewriting the natural scenes and patches stuff in #30 so IMO it's fine for now. At least until we have a writeup I don't think we'll have too much external traffic.

cshewmake2 commented 2 years ago

Yep. Realized that after I looked at #30. Thanks!

belsten commented 2 years ago

Can these requests be resolved so we can merge this branch?