rcyndie / QuartiCal

CubiCal, but with greater power.
MIT License
0 stars 0 forks source link

Bring branch up to date with upstream v0.2.1-dev. #1

Closed JSKenyon closed 1 year ago

JSKenyon commented 1 year ago

This merges in the additional changes from v0.2.1-dev and fixes some of the testing infrastructure.

@rcyndie, this is a PR into your tecest branch. I did it like this so that you can see see what I have changed. For now, please focus on getting test_tec_init.py working, and do not alter test_tec_and_offset.py. We can think about modifying the latter once the estimate only tests are passing.

I did make one change to your initial estimate code which seemed to necessary - I included a factor of 2pi in the sampled points. This seems to be consistent with the documentation and produces tec estimates quite close to the true values. Note that the tests are very close to passing - you may just need to figure out the oversampling factor to get the required accuracy/relax the accuracy of the tests.