rdkcentral / Lightning-SDK

SDK for Lightning framework
Apache License 2.0
130 stars 69 forks source link

add announcer plugin #384

Closed chiefcll closed 1 year ago

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

mhughesacn commented 1 year ago

Hi Chris: This is failing because it needs credit. Where did you get the code in utils.js?

(Credit is somewhat complicated. I think the following is a good source and would go under the Metrological Apache header.

Code from: https://github.com/jashkenas/underscore is Copyright (c) 2009-2022 Jeremy Ashkenas, Julian Gonggrijp, and DocumentCloud and Investigative Reporters & Editors Licensed under the MIT License based off: http://unscriptable.com/2009/03/20/debouncing-javascript-methods/ which is: Copyright (c) 2007-2009 unscriptable.com and John M. Hann Licensed under the MIT License

NOTICE should have the same text appended.

LICENSE needs a copy of the MIT license (with Copyright YEAR COPYRIGHT HOLDER i.e. the generic fields)

Thank you, Martin

chiefcll commented 1 year ago

Hopefully followed your instructions correctly... LMK

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 7134099740f973d7ce7ab2e5d09dce6eecc1565e Report detail: https://gist.github.com/rdkcmf-jenkins/2cf88c1f84afc3146b6079bd09d8695b

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 64b169f863752e2e75ba40ec224fcee8edea3722 Report detail: https://gist.github.com/rdkcmf-jenkins/e4161ad9dd1e4008d90c9a6a9578c50e

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 80785d78a65a77ab30db183a802205a34ba3226b Report detail: https://gist.github.com/rdkcmf-jenkins/5b8062fa4315bdba1e72e0508bdecc0e

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 1 year ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

jfboeve commented 1 year ago

Hey Chris,

I checked out the changed code and its looking a lot better! There are a few tiny things that need some adjusting:

michielvandergeest commented 1 year ago

@sandeep-vedam as discussed: can you please do some testing with this PR to validate if everything works as expected and evaluate if the documentation is clear enough. Thanks :)

rdkcmf-jenkins commented 1 year ago

Copyright scan failure

Commit: 09e839983da0095e7bccb19333b717a7e99c264b Report detail: https://gist.github.com/rdkcmf-jenkins/397f280c0dc15b078b7e18a73cd8d0aa

rdkcmf-jenkins commented 1 year ago

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

rdkcmf-jenkins commented 1 year ago

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

sandeep-vedam commented 1 year ago

Hey @chiefcll

I have tested this Announcer plugin with sample application(Router) and it seems to be fine.

Thanks, Sandeep.