Manager crashes when opening preferences dialog on Windows

[GoogleCodeExporter]

Since the recent changes to the advanced prefs dialog, opening prefs under 
Windows crashes the manager.

Attached stacktrace posted by DerMeister on June 18.

Original issue reported on code.google.com by nicolas....@gmail.com on 25 Jun 2010 at 12:08

Attachments:

• dermeister-stacktrace.txt

[GoogleCodeExporter]

After more than an hour of debugging in a VM (without the benefit of an IDE), I 
tracked this down.

I'm passing a certain wxControl pointer to buildLayout, and va_arg(ap, 
wxControl*) returns a totally different pointer value (!). Turns out the cause 
is that buildLayout is a variadic function whose last fixed argument is a 
reference type (const wxString&). Passing a reference type to va_start as last 
argument doesn't work as it should. When I changed it to pass the wxString by 
value, it didn't crash anymore.

Someone gave me these links, which explain the issue in detail:
http://support.microsoft.com/kb/119394/en-us/
http://stackoverflow.com/questions/222195

Fix pending.

Original comment by nicolas....@gmail.com on 25 Jun 2010 at 12:26

• Changed state: Started
• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

This issue was closed by revision r1432.

Original comment by nicolas....@gmail.com on 26 Jun 2010 at 1:09

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****