search

re-rxjs / react-rxjs.org

React-RxJS website
https://react-rxjs.org
0 stars 10 forks source link

Fix "see also" links on suspense page #55

Closed bruceharris closed 1 year ago

voliva commented 1 year ago

Hey @bruceharris, thank you for raising this.

However the links on https://react-rxjs.org/docs/api/core/suspense all seem to work on my end, is this the page the links are broken?

The CI flagged that the new links of this PR are broken.

Error: Broken links found!

- Page path = /docs/api/core/suspense:
   -> link to ../../utils/suspend (resolved as: /docs/utils/suspend)
   -> link to ../../utils/suspended (resolved as: /docs/utils/suspended)
bruceharris commented 1 year ago

Hmm, links go to "page not found" for me. broken links

voliva commented 1 year ago

Ok I see, it happens when accessing directly into the page. If you navigate through the menu to SUSPENSE, then the links work alright.

The only difference I see is that when navigating through the menu the URL doesn't end with /, whereas when navigating directly it does end with /. I'm thinking Docusaurs bug? I'll try to investigate later on.

voliva commented 1 year ago

Indeed, it was an issue on docusaurus + github pages: https://github.com/facebook/docusaurus/issues/5026

They released a newer version with a config option to fix it, so I raised #56 that does the upgrade and configures it.

bruceharris commented 1 year ago

👍 thanks @voliva !