search

react-community / reason-react-native-scripts

BSD 3-Clause "New" or "Revised" License
78 stars 12 forks source link

Could bs-platform be changed to a devDependency? #5

Open desmond-dsouza opened 6 years ago

desmond-dsouza commented 6 years ago

[Thank you sooo much for this project!]

Allows for a global install + npm link.

bs-react-native currently uses:

    "devDependencies": {
        "bs-platform": "^2.1.0",
        "reason-react": "^0.3.0"
    },
    "peerDependencies": {
        "reason-react": "^0.3.0",
        "react-native": "^0.46.0"
    }
brentvatne commented 6 years ago

makes sense, yeah we could do that

desmond-dsouza commented 6 years ago

ok, submitted a PR https://github.com/react-community/reason-react-native-scripts/pull/6

desmond-dsouza commented 6 years ago

Hmm. I don't think the packager can correctly handle symbolic links. Not sure.