search

react-native-community / docker-android

Android Docker Image for React Native and common android development.
MIT License
476 stars 144 forks source link

Ubuntu 20.04 does not support Ruby v3 and latest bundler (2.5+) #215

Open tuncaulubilge opened 9 months ago

tuncaulubilge commented 9 months ago

Latest version of bundler (2.5.0 and above), requires Ruby version >= 3.0.0. However, the community image for android is using Ubuntu 20.04 which does not support versions of ruby newer than 2.7.0

Here is the current error we see when installing bundler (Using fastlane for both iOS and android builds):

ERROR:  Error installing bundler:
    The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
    bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.0.0.

We can bypass this issue by adding -v 2.4.22 during gem install but it would be great to have a future proof solution that allows us to use newer Ruby and bundler versions.

cortinico commented 9 months ago

This image is for building Android, why do you need Ruby/Bundler?

tuncaulubilge commented 9 months ago

We use fastlane to build the Android app as well as the iOS apps, and use bundler to install fastlane as the recommended installation method.

cortinico commented 9 months ago

I see. We strive to keep this image as smaller as possible and don't account for all the possible use cases.

I'm happy to review a PR that will bump the image to Ubuntu 22.04 which will solve your issue.

tuncaulubilge commented 9 months ago

Thanks @cortinico, the PR is good to go 👍 https://github.com/react-native-community/docker-android/pull/216

tuncaulubilge commented 9 months ago

I see the PR merged but not auto-deployed. I suspect this might be the reason: https://github.com/react-native-community/docker-android/pull/217