Closed okwasniewski closed 2 months ago
Let me know if you prefer this to be handled in PrivacyManifestUtils
inside of Core
cc: @cipolleschi
Yeah, it would be better to fix it in Core. Otherwise this change will popup to every project that wants to migrate, while if we do it in core, the first time that users do pod install we will be able to fix the project for them.
Linking to the PR for visibility: https://github.com/facebook/react-native/pull/46457
Summary:
This PR fixes an issue with PrivacyInfo files.
When generating a new project for using the latest RC 0.76.0.rc0 I got two privacy manifests references in Xcode.
This is because
PrivacyManifestUtils
look for build phase reference:Which doesn't exist for the generated template.
Here is how Xcode file tree looks like after installing pods:
We can also fix this inside of
PrivacyManifestUtils
utility but Im not sure which one is better.When you create this file in Xcode its added to the
PBXBuildFile section
so the utility works good for existing projects, this issue only appears in newly generated projects.Changelog:
[IOS] [FIXED] - Don't add PrivacyInfo to Xcode references twice
Test Plan: