search

react-native-community / template

The React Native Community Template - getting started building RN apps for Android & iOS
MIT License
70 stars 16 forks source link

Remove native iOS tests #62

Closed okwasniewski closed 1 month ago

okwasniewski commented 1 month ago

Summary:

This PR removes native iOS tests as they are no longer used.

Unfortunately, this change creates a big diff in HelloWorld.xcodeproj/project.pbxproj We should annotate it in upgrade helper. But less code to maintain for users is always better 👍🏻

Manual Instruction for upgrade helper

  1. Open the xcworkspace
  2. Remove the target
  3. Open the Podfile
  4. Remove the section for the Tests
  5. rerun pod install.

Changelog:

[IOS] [REMOVED] - Native iOS tests

Test Plan:

  1. Create a new project
  2. Test if there is no sign of native tests in Xcode
  3. Build the app
thymikee commented 1 month ago

Can you add manual instructions of what needs to be changed in Xcode, so that it stays in this PR and can be easily referenced / copied over to the Upgrade Helper?

okwasniewski commented 1 month ago

@thymikee I've added additional instructions for manual steps in Xcode if users don't want to deal with editing the file manually

cipolleschi commented 1 month ago

Instructions could be simpler: it should be enough to:

  1. Open the xcworkspace
  2. Remove the target
  3. Open the Podfile
  4. Remove the section for the Tests
  5. rerun pod install.

Step 5 should take care of all the other parts.

okwasniewski commented 1 month ago

Thanks @cipolleschi, I upgraded the instructions

okwasniewski commented 1 month ago

Hey @cipolleschi is anything blocking the merge?

cipolleschi commented 1 month ago

Hey @cipolleschi is anything blocking the merge?

My (lack of) time! xD