react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Add option to specify app language for react-native-windows #293

Closed acoates-ms closed 3 years ago

acoates-ms commented 3 years ago

Summary

react-native-windows supports applications written in C++ or in CSharp. The current version of upgrade helper only allows users to view the diffs for C++ applications. This change adds an additional URL parameter for language, which can be either cpp, or cs. This will change which set of diffs get loaded - either the ones for C++ or CSharp apps.

Test Plan

Ran the test site, with package=react-native-windows. package=react-native-windows&language=cpp, package=react-native-windows&language=cs, and also react-native-windows&language=notreallang (to verify invalid input case).

Also tested language property with package=react-native to verify no effect.

What are the steps to reproduce?

Checklist