search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

chore(dependencies): upgrading the repo to more modern standards #345

Closed kelset closed 1 year ago

kelset commented 1 year ago

Summary

This is basically a follow up of https://github.com/react-native-community/upgrade-helper/pull/340 and https://github.com/react-native-community/upgrade-helper/pull/341

Problem is, things go 💣

Most of the packages I was able to upgrade easily, but now I'm getting screamed at from webpack because of antd.

The main two leftovers, as far as I can tell, are upgrading the design, stuff, so:

Both look pretty daunting, so I'm opening this as a WIP, and then we can see how to deal with it all going forward.

Test Plan

What are the steps to reproduce?

Checklist

kelset commented 1 year ago

headsup, fails when http://localhost:3000/upgrade-helper?from=0.69.2&to=0.70.7

error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'includes')
    at fetch-diff.js:8:1
    at Array.sort (<anonymous>)
    at movePackageJsonToTop (fetch-diff.js:7:1)
    at fetchDiff (fetch-diff.js:33:1)

will take a look at it later

lucasbento commented 1 year ago

Reverted react-diff-view upgrade, only 2.4.2 is working as >= 2.4.3 returns a difference output.

Issue: otakustay/react-diff-view#192.