react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Fix crash when upgrading from 0.68.6 or lower to 0.72.0 or higher #358

Closed ukcasso closed 1 year ago

ukcasso commented 1 year ago

Summary

  1. Preventing crashes when version files contain empty usefulContent.
  2. update 0.72 file in releases folder.

Test Plan

  1. select current react-native versions below 0.68.6.
  2. select upgrade 0.72.0 or higher version.
  3. click 'Show me how to upgrade!' button.
  4. web is crushed.
ukcasso commented 1 year ago

The usefulContent inside the a src/releases/react-native/0.72.js file seems to be more familiar to you.

pvinis commented 1 year ago

I see checks failing but if they pass we can merge. anyone with permissions.

ukcasso commented 1 year ago

thanks, @pvinis I'll wait until merged.

ukcasso commented 1 year ago

I canceled your approval due to my mistake. I would appreciate it if you could do it again. @pvinis.

pvinis commented 1 year ago

is your change just the if? is the other one accidental? this was there, right?

ukcasso commented 1 year ago

The cause of the crash is the 0.72.js file. The change in the usefulLinks.js file is again to prevent the web from being crushed by accidentally emptying the usefulContent in the release file.. :)

ukcasso commented 1 year ago

@pvinis , I solved the prettier problem.