search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

fix[Modified] UI Text Style Changed for Professional Look #93

Open piyushdevOP opened 3 years ago

piyushdevOP commented 3 years ago

*What kind of change does this PR introduce? UI look change.

Did you add tests for your changes? No

Summary

It was done to provide more professional look to the webapp.

Does this PR introduce a breaking change?

No

Other information

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 56f332b9fa94628f978e7c0287fb5419c825e6a3

https://deploy-preview-93--rne-playground.netlify.app

piyushdevOP commented 3 years ago

@pranshuchittora @Uyadav207 please look into it.

piyushdevOP commented 3 years ago

Thank you for your feedback. On it.

piyushdevOP commented 3 years ago

-> The UI is breaking , in mobile view there is no proper styling and spacing in the page title as well as in the navbar title. -> The Navbar seems to be missing as well. I don't think this change looks professional. Try fixing these issues.

Screenshot 2021-03-23 at 8 53 40 AM

https://user-images.githubusercontent.com/68142366/112175357-340adf00-8c1d-11eb-9398-37b4d1b078aa.mov

@shivambalwani @pranshuchittora @flyingcircle can you please look into it ? If there are any effects to be added to the UI , do let me know. I have some really good ideas for it.

piyushdevOP commented 3 years ago

--> The font styling is not Accurate compare it with original one. -->Just a Suggestion Rocket icon 🚀 on the nav bar looked great. Refer to Screen shots below:

Screenshot 2021-03-23 at 9 18 07 PM Screenshot 2021-03-23 at 9 19 52 PM

Thank you for your feedback. I tried changing the fontStyle to give a modern look to the UI. I can revert it if it's not looking nice.

Uyadav207 commented 3 years ago

@pranshuchittora @Uyadav207 please look into it.

Nice initiative, @piyushdevOP, but changing fonts doesn't add much... Try any other possible way to enhance the UI.

piyushdevOP commented 3 years ago

@pranshuchittora @Uyadav207 please look into it.

Nice initiative, @piyushdevOP, but changing fonts doesn't add much... Try any other possible way to enhance the UI.

  • only Revert the Fonts back.... Leave Mobile View as it is
  • The Icon Rocket looks great over there. isn't it ??

hey thanks for the feedback. I will revert back the fonts and come up with some better UI changes and effects if it's fine?

piyushdevOP commented 3 years ago

@Uyadav207 @shivambalwani @pranshuchittora I have restored the font back and added the rocket symbol. I haven't put the effects yet because I didn't get any go from you guys. Please do provide your valuable feedback. Should I do it? fixes #86

https://user-images.githubusercontent.com/68142366/112437183-ad651780-8d6c-11eb-8aa1-f54ece8255e7.mov

pranshuchittora commented 3 years ago

Oops! Conflicts. I think this is not required

piyushdevOP commented 3 years ago

Oops! Conflicts. I think this is not required

Esteemed Sir, the burger button display issue in mobile view is fixed in this PR only. Should I go ahead and resolve the conflicts so that the mobile view issue could be fixed? It would be great of you if you could tell me how to proceed .

piyushdevOP commented 3 years ago

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

Uyadav207 commented 3 years ago

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

React View ??

piyushdevOP commented 3 years ago

@shivambalwani @Uyadav207 kindly look into it. I was facing some dependency issues. I have fixed it.Please do suggest some changes if required.

React View ??

Something like V8 was missing. I have resolved the conflicts. It would be of great help if you could tell me what I have done is acceptable or not. I am kinda new to open source 😃