#31 #37 - Use inputHeight prop to actually set the height of the input

react-native-vietnam / react-native-search-box

A simple search box with animation, inspired from ios search bar. Lightweight, fast, flexible.

476 stars 132 forks source link

#31 #37 - Use inputHeight prop to actually set the height of the input #66

Closed se1exin closed 4 years ago

se1exin commented 6 years ago

The containerHeight was previously hardcoded to 40, meaning that inputHeight prop was not actually useful if you wanted to go taller than 40.

This pull request changes the height of both the Container and the Input to respect the passed inputHeight prop, which also fixes issue #31 . The existing default of 30 for Input Height is maintained, along with the Container height of 40 via the formula inputHeight + 10 set in the Stylesheet

timwangdev commented 6 years ago

Maybe we can also remove Line 273 because it's redundant.

prscX commented 5 years ago

Hi: Could someone please merge the PR. It is needed and useful to control container size for Phone and Tablet devices.

Thanks </ Pranav >