Internal onFocus function throws an error on react-native 0.62

react-native-vietnam / react-native-search-box

A simple search box with animation, inspired from ios search bar. Lightweight, fast, flexible.

476 stars 132 forks source link

Internal onFocus function throws an error on react-native 0.62 #83

Closed akread closed 4 years ago

akread commented 4 years ago

On both iOS and Android, https://github.com/react-native-vietnam/react-native-search-box/blob/master/index.js#L130 throws an error on react-native 0.62. This is breaking functionality.

Another warning that showed up after I updated to react-native 0.62 on my project from this package is that Animated.useDriver must be explicitly defined and is not. This one doesn't actually stop things from working but worth noting.

akread commented 4 years ago

It looks most definitely related to https://github.com/facebook/react-native/commit/bbc5c35a61cd3af47ccb2dc62430e4b6a4d4e08f.

akread commented 4 years ago

It was a simple fix. I proposed a PR https://github.com/react-native-vietnam/react-native-search-box/pull/84 to fix the issue and am going to use the package pinned to this commit on my app temporarily.