search

react-navigation / web

Tools for react-navigation on web browsers and servers
https://reactnavigation.org
MIT License
94 stars 28 forks source link

only set document.title if truthy value provided #17

Closed chunghe closed 5 years ago

chunghe commented 5 years ago

If html template already set document.title and user just want to use the document.title defined in the html template, he can choose not to set opts.title or opts.headerTitle.

Current implementation will set undefined as document title.

@ericvicenti really appreciate to have to take a look at this PR, thanks!

ericvicenti commented 5 years ago

This makes sense, thank you!