Closed WesSouza closed 2 years ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
react95 | ✅ Ready (Inspect) | Visit Preview | Aug 4, 2022 at 8:58PM (UTC) |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 4724175b335b636f3bc6e7162ccc3223392f7de5:
Sandbox | Source |
---|---|
React95 template | Configuration |
@arturbien @luizbaldi although this exported files on the correct locations, it still didn't generate one file per theme as expected.
Any objection to either:
react95
and only have one entryIdeally we should expose all components and themes in a way that would allow devs to import only the things they need (like MUI does):
import Button from '@mui/material/Button';
I am worried that if we bundle themes together, we're going to increase the bundle size. Especially if we keep adding more and more themes. I'll try to look into that during the weekend.
@luizbaldi any ideas?
@arturbien then we need to change rollup for the main entry too, it currently bundles the entire file into one export.
An alternative to #329, passing specific TypeScript
compilerOptions
torollup-plugin-dts
.