search

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.36k stars 2.18k forks source link

Fixed Typo in applyPromotion.test.js and applyPromotions.js of promotion #6861

Closed asharan2511 closed 1 year ago

asharan2511 commented 1 year ago

Resolves #6811 Impact: minor Type: bug

Issue

The message says that there is Typo error which needs to be changed from "The promotion no longer available" to "Promotion is no longer available".

Solution

successfully corrected the typo as mentioned in the bug description in the following paths 1.packages\api-plugin-promotions\src\handlers\applyPromotions.test.js 2.packages\api-plugin-promotions\src\handlers\applyPromotions.js

Breaking changes

NA

Testing

1.Changed expect(cart.messages[0].title).toEqual("The promotion no longer available"); to expect(cart.messages[0].title).toEqual("Promotion is no longer available"); 2.Can add expect(cart.messages[0].requiresReadAcknowledgement).toEqual(true); in packages/api-plugin-promotions/src/handlers/applyPromotions.test.js to test whether requiresReadAcknowledgement is set to true or not.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: e516b7181f690da300dbad2ecfaaec613e2ace1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR