search

reactiverse / aws-sdk

Using vertx-client for AWS SDK v2
Apache License 2.0
49 stars 14 forks source link

Version > 2.20.75 of aws-sdk will in some cases not function with the reactiverse client #65

Closed mikand13 closed 1 year ago

mikand13 commented 1 year ago

In my case it concerns the S3 SDK.

L39 of WriteStreamSubscriber.java crashes when calling byteBuffer.array() because the S3 SDK passes a bytebuffer that is backed by an array but is read-only.

From docs:

ReadOnlyBufferException - If this buffer is backed by an array but is read-only

This prevents us from upgrading beyong 2.20.75

aesteve commented 1 year ago

Thanks a lot for reporting this ahead of time for the migration, this helped a lot.

I was able to reproduce in #66 and published a snapshot version here: https://oss.sonatype.org/content/repositories/snapshots/io/reactiverse/aws-sdk/1.2.2-SNAPSHOT/

Would you potentially have time to try this version locally and see if this fixes everything for you (and doesn't introduce any regression, too).

Thanks again!

mikand13 commented 1 year ago

Can do 👌

aesteve commented 1 year ago

Hello,

I'm not exactly sure how long snapshots are available for on Nexus (I think it might be 30 days?) but in case the link above becomes unavailable please ping me.

Let me know if your tests are running fine so that I can release 1.2.2.

Thank you.

mikand13 commented 1 year ago

Yeah, sorry. I'm on it, but im away from work atm. We're testing it in an underlying lib now which will go into mainline in the near future bar any issues. Seems to work fine so far, just wanted to verify with the code that experienced the issue.

mikand13 commented 1 year ago

Seems to work just fint @aesteve . Any timeline for 1.2.2?

aesteve commented 1 year ago

You should be good now: https://central.sonatype.com/artifact/io.reactiverse/aws-sdk/versions

Ping me if it's not the case! Thanks for reporting.