search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
10.86k stars 7.45k forks source link

fix: update SidebarNav component style #6943

Open victorlunam opened 2 weeks ago

victorlunam commented 2 weeks ago

considering that the grid-template for the “lg” breakpoint is “grid-cols-sidebar-content”.

https://github.com/reactjs/react.dev/blob/b12743c31af7f5cda2c25534f64281ff030b7205/src/components/Layout/Page.tsx#L146-L150

https://github.com/reactjs/react.dev/blob/b12743c31af7f5cda2c25534f64281ff030b7205/tailwind.config.js#L155-L159

and the fixed width of the SidebarNav in:

https://github.com/reactjs/react.dev/blob/b12743c31af7f5cda2c25534f64281ff030b7205/src/components/Layout/SidebarNav/SidebarNav.tsx#L37-L37

I think the “20rem” width might not be enough, considering the fixed width of the SidebarNav.

I think we could consider that the width should be defined in the grid-template.

Issue solved

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 3:34pm
react-dev ✅ Ready (Inspect) Visit Preview Jun 11, 2024 3:34pm
facebook-github-bot commented 2 weeks ago

Hi @victorlunam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

github-actions[bot] commented 2 weeks ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 ### Five Pages Changed Size The following pages changed size from the code in this PR compared to its base branch: Page | Size (compressed) | First Load | |---|---|---| | `/404` | `80.78 KB` _(🟢 -10 B)_ | 184.92 KB | | `/500` | `80.77 KB` _(🟢 -10 B)_ | 184.92 KB | | `/[[...markdownPath]]` | `82.62 KB` _(🟢 -10 B)_ | 186.77 KB | | `/errors` | `80.99 KB` _(🟢 -10 B)_ | 185.13 KB | | `/errors/[errorCode]` | `80.97 KB` _(🟢 -10 B)_ | 185.11 KB |
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

facebook-github-bot commented 2 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!