search

reactor / reactor-netty

TCP/HTTP/UDP/QUIC client/server with Reactor over Netty
https://projectreactor.io
Apache License 2.0
2.61k stars 647 forks source link

Ensure `HttpInfos#version` returns the correct protocol #3487

Closed violetagg closed 3 weeks ago

violetagg commented 3 weeks ago

Fixes #3475

violetagg commented 3 weeks ago

I understand for 1.2.x the implementation would need to also consider H3 so a boolean isHttp2 probably can't be used there, but for 1.1.x it looks this patch provides what's needed 👍

We have Http3ServerOperations so we will override those methods as we do for local/remote address https://github.com/reactor/reactor-netty/blob/main/reactor-netty-http/src/main/java/reactor/netty/http/server/Http3ServerOperations.java

For the client - yes we will need something else.