Closed WyriHaximus closed 1 year ago
@clue I assume most of the location related comments also go for the promise counter parts?
+1+1+1
Needed to highlight how much I like this change despite all the nit-picking in this review. Keep it up!
Much appreciated @clue . Updated this PR, and https://github.com/reactphp/promise/pull/227 (and https://github.com/reactphp/promise/pull/228) with related changes.
These annotations will aid static analyses like PHPStan and Psalm to enhance type-safety for this project and projects depending on it
These changes make the following example understandable by PHPStan:
This PR builds on the discussion at https://github.com/vimeo/psalm/discussions/7559 and the following PR's https://github.com/reactphp/promise/pull/247, https://github.com/reactphp/promise/pull/246, and others down the line.