search

reactphp / async

Async utilities and fibers for ReactPHP.
https://reactphp.org/async/
MIT License
204 stars 19 forks source link

Add execution order test #63

Closed kelunik closed 1 year ago

kelunik commented 2 years ago

This test currently has a different execution order in my adapter, so let's document the expected execution order.

kelunik commented 2 years ago

@SimonFrings Done. 👍

SimonFrings commented 2 years ago

@kelunik thanks for the update 👍

The test itself in its functionality and the overall design looks great. I talked with @clue about this and it looks like your testcase is already covered by other tests and didn't raise the overall code coverage.

I would argue that it wouldn't make sense to add a test just to show a specific example of what is possible.

clue commented 1 year ago

I'm closing this for now as it hasn't received any input in a while and I believe this has been answered. If you feel this is still relevant, please come back with more details and we can always reopen this :+1:

Thank you for your effort nonetheless, keep it up! :+1: