Smallimprovs - Githubissues

readchina / comics

Comics repo

https://readchina.github.io/comics/

1 stars 0 forks source link

Smallimprovs #23

Closed damianodamiani closed 2 years ago

damianodamiani commented 2 years ago

As per issue #21, I have:

made all titles start with capital letter
changed 'panel' to 'page' everywhere (a few 'panels' are left in the intros where the discussion is about the image only)
added Chinese titles to the comics titles as well as the year
moved the References to the Intro to the comics
changed "Notes to the translation" to "About the translation"
changed "cover" to "Front and back cover"
changed "front" to "Frontmatter"
fixed a few typos here and there

If merged, this also resolves #8 #10 #20 #21

The last thing open, but I don't know how to do it, is to add a larger logo to the main index page -- perhaps you need to look at this @duncdrum, or send me related how to info, and I try again!

LenaHenningsen commented 2 years ago

Hi Damian, I like the changes a lot. In The Watch and New Year, it's still Introduction to Text; and I am hesitant to merge, because here https://readchina.github.io/comics/the-new-years-sacrifice/b-cover/ for example it is already panel in the left hand navigation bar.

damianodamiani commented 2 years ago

Sorry, didn't see the missing 'the' issues -- fixed.

The local build looks like this for me, no 'panels' in the navbar:

damianodamiani commented 2 years ago

lets keep pages for now, as I just changed them so a bit mafan to re-change -- but we could keep that question open because it is interesting: how do we call the pages/panels in a lianhuanhua actually? we can then change that later on

about the () issue: wouldn't it work if we kept the URLs as are (so just the english title and no year) but have chinese and year on the page? I don't have an issue with that, it's fairly usual that URLs are short versions, or?

I can adjust readme and config already, one second

LenaHenningsen commented 2 years ago

Thanks, and I was confused again. All fine by me!!!

Von: Damian @.> Antworten an: readchina/comics @.> Datum: Dienstag, 15. März 2022 um 15:32 An: readchina/comics @.> Cc: LenaHenningsen @.>, Review requested @.***> Betreff: Re: [readchina/comics] Smallimprovs (PR #23)

Sorry, didn't see the missing 'the' issues -- fixed.

The local build looks like this for me, no 'panels' in the navbar:

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because your review was requested.Message ID: @.***>

damianodamiani commented 2 years ago

@duncdrum I adjusted readme, but don't really know what the other points you raised mean :( Does the URL trick as suggested above solve the issue?